From e127b404f9381aae0010ca86502108af83d2c384 Mon Sep 17 00:00:00 2001
From: Florian <flo@meergans.org>
Date: Sat, 8 Nov 2025 12:41:48 +0100
Subject: [PATCH] SonarQube linting

---
 src/dockerhub_api.py | 10 +++++-----
 src/github_api.py    |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/dockerhub_api.py b/src/dockerhub_api.py
index 872334f..d0f4194 100644
--- a/src/dockerhub_api.py
+++ b/src/dockerhub_api.py
@@ -27,10 +27,10 @@ def login_and_get_token() -> str:
 			return token
 		else:
 			logger.error("[DockerHub] Login response did not contain token")
-			return None
+			return ""
 	else:
 		logger.error(f"[DockerHub] Login failed: {response.status_code} - {response.text}")
-		return None
+		return ""
 
 
 def find_package_version_with_tag(repo: str, tag: str) -> str:
@@ -43,7 +43,7 @@ def find_package_version_with_tag(repo: str, tag: str) -> str:
 	token = login_and_get_token()
 	if not token:
 		logger.error(f"[DockerHub] Cannot fetch tag '{tag}' for repo '{repo}' without token")
-		return None
+		return ""
 
 	headers = {"Authorization": f"JWT {token}"}
 	tags_url = f"https://hub.docker.com/v2/repositories/{repo}/tags/{tag}?page_size=1"
@@ -51,7 +51,7 @@ def find_package_version_with_tag(repo: str, tag: str) -> str:
 	response = requests.get(tags_url, headers=headers)
 	if response.status_code != 200:
 		logger.error(f"[DockerHub] Failed to fetch tag '{tag}' for repo '{repo}': {response.status_code} - {response.text}")
-		return None
+		return ""
 
 	data = response.json()
 	tag_id = data.get("id")
@@ -60,7 +60,7 @@ def find_package_version_with_tag(repo: str, tag: str) -> str:
 		return str(tag_id)
 	else:
 		logger.debug(f"[DockerHub] Tag '{tag}' not found for repo '{repo}'")
-		return None
+		return ""
 
 
 if __name__ == "__main__":
diff --git a/src/github_api.py b/src/github_api.py
index d60d1d1..afb8720 100644
--- a/src/github_api.py
+++ b/src/github_api.py
@@ -27,12 +27,12 @@ def find_package_version_with_tag(org: str, package: str, target_tag: str) -> st
 		response = requests.get(url, headers=headers, params=params)
 		if response.status_code != 200:
 			logger.error(f"[GitHub] Error {response.status_code} fetching {package}: {response.text}")
-			return None
+			return ""
 
 		versions = response.json()
 		if not versions:
 			logger.debug(f"[GitHub] Reached end of pages — tag '{target_tag}' not found for {package}.")
-			return None
+			return ""
 
 		for version in versions:
 			tags = version.get("metadata", {}).get("container", {}).get("tags", [])