From 3ceaf3f45503381b4727ba6935074aa0470a74be Mon Sep 17 00:00:00 2001 From: florian Date: Mon, 3 Nov 2025 19:47:37 +0100 Subject: [PATCH] Moved logging setup to seperate module --- Dockerfile | 2 ++ requirements.txt | 1 + src/db.py | 2 +- src/dockerhub_api.py | 2 +- src/github_api.py | 2 +- src/logger_handler.py | 30 ------------------------------ src/main.py | 2 +- src/secret_handler.py | 2 +- src/send_notification.py | 2 +- 9 files changed, 9 insertions(+), 36 deletions(-) delete mode 100644 src/logger_handler.py diff --git a/Dockerfile b/Dockerfile index a54e052..bf6c867 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,7 @@ FROM python:3.12-slim +RUN apt-get update && apt-get install -y git + COPY requirements.txt . RUN pip install --no-cache-dir -r requirements.txt diff --git a/requirements.txt b/requirements.txt index 0ff6274..48f35d9 100644 --- a/requirements.txt +++ b/requirements.txt @@ -11,6 +11,7 @@ prometheus_client==0.23.1 pydantic==2.12.0 pydantic_core==2.41.1 python-json-logger==4.0.0 +simple-logger-handler @ git+https://git.gansejunge.com/notifier/lib-logger-handler.git@main requests==2.32.5 sniffio==1.3.1 starlette==0.48.0 diff --git a/src/db.py b/src/db.py index fa6b16e..11ef0ae 100644 --- a/src/db.py +++ b/src/db.py @@ -3,7 +3,7 @@ import threading from secret_handler import return_credentials import os import time -from logger_handler import setup_logger +from simple_logger_handler import setup_logger db_username = return_credentials("/etc/secrets/db_username") db_password = return_credentials("/etc/secrets/db_password") diff --git a/src/dockerhub_api.py b/src/dockerhub_api.py index fbf04be..3b8c4df 100644 --- a/src/dockerhub_api.py +++ b/src/dockerhub_api.py @@ -1,6 +1,6 @@ import requests from secret_handler import return_credentials -from logger_handler import setup_logger +from simple_logger_handler import setup_logger dockerhub_token = return_credentials("/etc/secrets/dockerhub_token") dockerhub_username = return_credentials("/etc/secrets/dockerhub_username") diff --git a/src/github_api.py b/src/github_api.py index 027a32f..969f2cf 100644 --- a/src/github_api.py +++ b/src/github_api.py @@ -1,6 +1,6 @@ import requests from secret_handler import return_credentials -from logger_handler import setup_logger +from simple_logger_handler import setup_logger github_token = return_credentials("/etc/secrets/github_token") logger = setup_logger(__name__) diff --git a/src/logger_handler.py b/src/logger_handler.py deleted file mode 100644 index c504d1e..0000000 --- a/src/logger_handler.py +++ /dev/null @@ -1,30 +0,0 @@ -import os -import logging - -try: - from pythonjsonlogger import jsonlogger - JSON_LOGGING = True -except ImportError: - JSON_LOGGING = False - -LOG_LEVEL = os.getenv("LOG_LEVEL", "INFO").upper() -if LOG_LEVEL not in {"ERROR", "DEBUG", "INFO", "WARNING", "CRITICAL"}: - LOG_LEVEL = "INFO" - -def setup_logger(name: str) -> logging.Logger: - logger = logging.getLogger(name) - if not logger.handlers: - handler = logging.StreamHandler() - if JSON_LOGGING: - formatter = jsonlogger.JsonFormatter( - "%(asctime)s %(name)s %(levelname)s %(message)s" - ) - else: - formatter = logging.Formatter( - "%(asctime)s - %(name)s - %(levelname)s - %(message)s" - ) - handler.setFormatter(formatter) - logger.addHandler(handler) - logger.setLevel(getattr(logging, LOG_LEVEL)) - logger.debug(f"Logger {name} initialized with level {LOG_LEVEL}") - return logger diff --git a/src/main.py b/src/main.py index 1fc4c2d..7cb1b1d 100644 --- a/src/main.py +++ b/src/main.py @@ -5,7 +5,7 @@ from dockerhub_api import find_package_version_with_tag as find_package_version_ import uvicorn from contextlib import asynccontextmanager from db import get_db, create_connection_pool, close_connection_pool, start_healthcheck_thread -from logger_handler import setup_logger, LOG_LEVEL +from simple_logger_handler import setup_logger, LOG_LEVEL from send_notification import send_notification from metrics_server import REQUEST_COUNTER import asyncio diff --git a/src/secret_handler.py b/src/secret_handler.py index 639a2a1..4530e7b 100644 --- a/src/secret_handler.py +++ b/src/secret_handler.py @@ -1,4 +1,4 @@ -from logger_handler import setup_logger +from simple_logger_handler import setup_logger logger = setup_logger(__name__) diff --git a/src/send_notification.py b/src/send_notification.py index 3aad89f..6435967 100644 --- a/src/send_notification.py +++ b/src/send_notification.py @@ -4,7 +4,7 @@ from fastapi import HTTPException from secret_handler import return_credentials import os import time -from logger_handler import setup_logger +from simple_logger_handler import setup_logger backend_api_url=os.getenv("BACKEND_API_URL","localhost:8101/internal/receive-notifications")